natto1784/gitea-release-resource
1
0
Fork 0
Code Issues 1 Pull Requests Projects Releases Wiki Activity

do not fail if there are no releases

Browse Source 
they might just not be created yet
This commit is contained in:
Alex Suraci
2015-08-08 11:53:25 -07:00
parent d2c9a5e136
commit b682cc93ad
2 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
check_command.go
View File

@@ -1,7 +1,6 @@
package resource package resource
import ( import (
"errors"
"sort" "sort"
"github.com/blang/semver" "github.com/blang/semver"
@@ -25,7 +24,7 @@ func (c *CheckCommand) Run(request CheckRequest) ([]Version, error) {
} }
if len(releases) == 0 { if len(releases) == 0 {
return []Version{}, errors.New("repository had no releases") return []Version{}, nil
} }
sort.Sort(byVersion(releases)) sort.Sort(byVersion(releases))

14
check_command_test.go
View File

@@ -35,9 +35,10 @@ var _ = Describe("Check Command", func() {
returnedReleases = []github.RepositoryRelease{} returnedReleases = []github.RepositoryRelease{}
}) })
It("returns an error when there are no releases", func() { It("returns no versions", func() {
_, err := command.Run(resource.CheckRequest{}) versions, err := command.Run(resource.CheckRequest{})
Ω(err).Should(HaveOccurred()) Ω(err).ShouldNot(HaveOccurred())
Ω(versions).Should(BeEmpty())
}) })
}) })
@@ -70,9 +71,10 @@ var _ = Describe("Check Command", func() {
returnedReleases = []github.RepositoryRelease{} returnedReleases = []github.RepositoryRelease{}
}) })
It("returns an error when there are no releases", func() { It("returns no versions", func() {
_, err := command.Run(resource.CheckRequest{}) versions, err := command.Run(resource.CheckRequest{})
Ω(err).Should(HaveOccurred()) Ω(err).ShouldNot(HaveOccurred())
Ω(versions).Should(BeEmpty())
}) })
}) })