From b682cc93ad7ef5a71d1e065ffc3ee5f86cdce8ee Mon Sep 17 00:00:00 2001 From: Alex Suraci Date: Sat, 8 Aug 2015 11:53:25 -0700 Subject: [PATCH] do not fail if there are no releases they might just not be created yet --- check_command.go | 3 +-- check_command_test.go | 14 ++++++++------ 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/check_command.go b/check_command.go index 89fc9ae..aa19b00 100644 --- a/check_command.go +++ b/check_command.go @@ -1,7 +1,6 @@ package resource import ( - "errors" "sort" "github.com/blang/semver" @@ -25,7 +24,7 @@ func (c *CheckCommand) Run(request CheckRequest) ([]Version, error) { } if len(releases) == 0 { - return []Version{}, errors.New("repository had no releases") + return []Version{}, nil } sort.Sort(byVersion(releases)) diff --git a/check_command_test.go b/check_command_test.go index a8722fe..5895a71 100644 --- a/check_command_test.go +++ b/check_command_test.go @@ -35,9 +35,10 @@ var _ = Describe("Check Command", func() { returnedReleases = []github.RepositoryRelease{} }) - It("returns an error when there are no releases", func() { - _, err := command.Run(resource.CheckRequest{}) - Ω(err).Should(HaveOccurred()) + It("returns no versions", func() { + versions, err := command.Run(resource.CheckRequest{}) + Ω(err).ShouldNot(HaveOccurred()) + Ω(versions).Should(BeEmpty()) }) }) @@ -70,9 +71,10 @@ var _ = Describe("Check Command", func() { returnedReleases = []github.RepositoryRelease{} }) - It("returns an error when there are no releases", func() { - _, err := command.Run(resource.CheckRequest{}) - Ω(err).Should(HaveOccurred()) + It("returns no versions", func() { + versions, err := command.Run(resource.CheckRequest{}) + Ω(err).ShouldNot(HaveOccurred()) + Ω(versions).Should(BeEmpty()) }) })