natto1784/gitea-release-resource
1
0
Fork 0
Code Issues 1 Pull Requests Projects Releases Wiki Activity

Return on error to avoid dereference errors

Browse Source
This commit is contained in:
Christoph Sassenberg
2018-01-24 09:03:54 +01:00
parent 5819c61aa6
commit d9e71688fc
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
in_command.go
View File

@@ -199,10 +199,13 @@ func (c *InCommand) downloadFile(url, destPath string) error {
func (c *InCommand) resolveTagToCommitSHA(tag string) (string, error) { func (c *InCommand) resolveTagToCommitSHA(tag string) (string, error) {
reference, err := c.github.GetRef(tag) reference, err := c.github.GetRef(tag)
if err != nil {
return "", err
}
if err != nil && *reference.Object.Type != "commit" { if *reference.Object.Type != "commit" {
fmt.Fprintln(c.writer, "could not resolve tag '%s' to commit: returned type is not 'commit' - only lightweight tags are supported") fmt.Fprintln(c.writer, "could not resolve tag '%s' to commit: returned type is not 'commit' - only lightweight tags are supported")
return "", nil return "", err
} }
return *reference.Object.SHA, err return *reference.Object.SHA, err