remove latest release from github client

[#102513822]

Signed-off-by: Evan Short <eshort@pivotal.io>
This commit is contained in:
Toby Rumans
2015-09-11 17:11:52 -07:00
committed by Evan Short
parent 22d247be7d
commit b694a6e9c9
2 changed files with 1 additions and 48 deletions

View File

@@ -14,17 +14,10 @@ type FakeGitHub struct {
ListReleasesStub func() ([]github.RepositoryRelease, error) ListReleasesStub func() ([]github.RepositoryRelease, error)
listReleasesMutex sync.RWMutex listReleasesMutex sync.RWMutex
listReleasesArgsForCall []struct{} listReleasesArgsForCall []struct{}
listReleasesReturns struct { listReleasesReturns struct {
result1 []github.RepositoryRelease result1 []github.RepositoryRelease
result2 error result2 error
} }
LatestReleaseStub func() (*github.RepositoryRelease, error)
latestReleaseMutex sync.RWMutex
latestReleaseArgsForCall []struct{}
latestReleaseReturns struct {
result1 *github.RepositoryRelease
result2 error
}
GetReleaseByTagStub func(tag string) (*github.RepositoryRelease, error) GetReleaseByTagStub func(tag string) (*github.RepositoryRelease, error)
getReleaseByTagMutex sync.RWMutex getReleaseByTagMutex sync.RWMutex
getReleaseByTagArgsForCall []struct { getReleaseByTagArgsForCall []struct {
@@ -115,31 +108,6 @@ func (fake *FakeGitHub) ListReleasesReturns(result1 []github.RepositoryRelease,
}{result1, result2} }{result1, result2}
} }
func (fake *FakeGitHub) LatestRelease() (*github.RepositoryRelease, error) {
fake.latestReleaseMutex.Lock()
fake.latestReleaseArgsForCall = append(fake.latestReleaseArgsForCall, struct{}{})
fake.latestReleaseMutex.Unlock()
if fake.LatestReleaseStub != nil {
return fake.LatestReleaseStub()
} else {
return fake.latestReleaseReturns.result1, fake.latestReleaseReturns.result2
}
}
func (fake *FakeGitHub) LatestReleaseCallCount() int {
fake.latestReleaseMutex.RLock()
defer fake.latestReleaseMutex.RUnlock()
return len(fake.latestReleaseArgsForCall)
}
func (fake *FakeGitHub) LatestReleaseReturns(result1 *github.RepositoryRelease, result2 error) {
fake.LatestReleaseStub = nil
fake.latestReleaseReturns = struct {
result1 *github.RepositoryRelease
result2 error
}{result1, result2}
}
func (fake *FakeGitHub) GetReleaseByTag(tag string) (*github.RepositoryRelease, error) { func (fake *FakeGitHub) GetReleaseByTag(tag string) (*github.RepositoryRelease, error) {
fake.getReleaseByTagMutex.Lock() fake.getReleaseByTagMutex.Lock()
fake.getReleaseByTagArgsForCall = append(fake.getReleaseByTagArgsForCall, struct { fake.getReleaseByTagArgsForCall = append(fake.getReleaseByTagArgsForCall, struct {

View File

@@ -15,7 +15,6 @@ import (
type GitHub interface { type GitHub interface {
ListReleases() ([]github.RepositoryRelease, error) ListReleases() ([]github.RepositoryRelease, error)
LatestRelease() (*github.RepositoryRelease, error)
GetReleaseByTag(tag string) (*github.RepositoryRelease, error) GetReleaseByTag(tag string) (*github.RepositoryRelease, error)
CreateRelease(release github.RepositoryRelease) (*github.RepositoryRelease, error) CreateRelease(release github.RepositoryRelease) (*github.RepositoryRelease, error)
UpdateRelease(release github.RepositoryRelease) (*github.RepositoryRelease, error) UpdateRelease(release github.RepositoryRelease) (*github.RepositoryRelease, error)
@@ -77,20 +76,6 @@ func (g *GitHubClient) ListReleases() ([]github.RepositoryRelease, error) {
return releases, nil return releases, nil
} }
func (g *GitHubClient) LatestRelease() (*github.RepositoryRelease, error) {
latest, res, err := g.client.Repositories.GetLatestRelease(g.user, g.repository)
if err != nil {
return &github.RepositoryRelease{}, nil
}
err = res.Body.Close()
if err != nil {
return nil, err
}
return latest, nil
}
func (g *GitHubClient) GetReleaseByTag(tag string) (*github.RepositoryRelease, error) { func (g *GitHubClient) GetReleaseByTag(tag string) (*github.RepositoryRelease, error) {
release, res, err := g.client.Repositories.GetReleaseByTag(g.user, g.repository, tag) release, res, err := g.client.Repositories.GetReleaseByTag(g.user, g.repository, tag)
if err != nil { if err != nil {