access token is now optional

* fix some err checks
* github api url can be configured (e.g. point it at an enterprise instance)

[finishes #89638752 #89633744]

Signed-off-by: Chris Brown <cbrown@pivotal.io>
This commit is contained in:
Alex Suraci
2015-03-04 12:25:26 -08:00
committed by Chris Brown
parent 9e289b62c6
commit 4dbe94c715
9 changed files with 174 additions and 17 deletions

View File

@@ -25,9 +25,14 @@ func NewInCommand(github GitHub, writer io.Writer) *InCommand {
}
func (c *InCommand) Run(destDir string, request InRequest) (InResponse, error) {
err := os.MkdirAll(destDir, 0755)
if err != nil {
return InResponse{}, err
}
releases, err := c.github.ListReleases()
if err != nil {
return InResponse{}, nil
return InResponse{}, err
}
sort.Sort(byVersion(releases))
@@ -55,7 +60,7 @@ func (c *InCommand) Run(destDir string, request InRequest) (InResponse, error) {
assets, err := c.github.ListReleaseAssets(foundRelease)
if err != nil {
return InResponse{}, nil
return InResponse{}, err
}
for _, asset := range assets {
@@ -87,7 +92,7 @@ func (c *InCommand) Run(destDir string, request InRequest) (InResponse, error) {
err := c.downloadFile(url, path)
if err != nil {
return InResponse{}, nil
return InResponse{}, err
}
}