natto1784/gitea-release-resource
1
0
Fork 0
Code Issues 1 Pull Requests Projects Releases Wiki Activity

Remove checking for nil version on in command

Browse Source 
[#102513822]

Signed-off-by: Toby Rumans <trumans@pivotal.io>
This commit is contained in:
Evan Short
2015-09-11 17:07:03 -07:00
committed by Toby Rumans
parent 6d9ae63167
commit 22d247be7d
2 changed files with 3 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files

78
in_command_test.go
View File

@@ -181,60 +181,6 @@ var _ = Describe("In Command", func() {
})
})
})
Context("when the version is not specified", func() {
BeforeEach(func() {
githubClient.LatestReleaseReturns(buildRelease(1, "v0.37.0"), nil)
githubClient.ListReleaseAssetsReturns([]github.ReleaseAsset{
buildAsset(0, "something.tgz"),
}, nil)
inRequest.Version = nil
inResponse, inErr = command.Run(destDir, inRequest)
})
It("succeeds", func() {
Ω(inErr).ShouldNot(HaveOccurred())
Ω(githubClient.GetReleaseByTagCallCount()).Should(Equal(0))
})
It("returns the fetched version", func() {
Ω(inResponse.Version).Should(Equal(resource.Version{Tag: "v0.37.0"}))
})
It("has some sweet metadata", func() {
Ω(inResponse.Metadata).Should(ConsistOf(
resource.MetadataPair{Name: "url", Value: "http://google.com"},
resource.MetadataPair{Name: "name", Value: "release-name", URL: "http://google.com"},
resource.MetadataPair{Name: "body", Value: "*markdown*", Markdown: true},
))
})
It("stores git tag in a file", func() {
_, err := os.Stat(filepath.Join(destDir, "tag"))
Ω(err).ShouldNot(HaveOccurred())
tag, err := ioutil.ReadFile(filepath.Join(destDir, "tag"))
Ω(err).ShouldNot(HaveOccurred())
Ω(string(tag)).Should(Equal("v0.37.0"))
})
It("stores version in a file", func() {
_, err := os.Stat(filepath.Join(destDir, "version"))
Ω(err).ShouldNot(HaveOccurred())
version, err := ioutil.ReadFile(filepath.Join(destDir, "version"))
Ω(err).ShouldNot(HaveOccurred())
Ω(string(version)).Should(Equal("0.37.0"))
})
It("fetches from the latest release", func() {
Ω(githubClient.DownloadReleaseAssetArgsForCall(0)).Should(Equal(buildAsset(0, "something.tgz")))
})
})
})
Context("when no tagged release is present", func() {
@@ -253,17 +199,6 @@ var _ = Describe("In Command", func() {
})
})
Context("when no latest release is present", func() {
BeforeEach(func() {
githubClient.LatestReleaseReturns(nil, nil)
inResponse, inErr = command.Run(destDir, inRequest)
})
It("returns an error", func() {
Ω(inErr).Should(MatchError("no releases"))
})
})
Context("when getting a tagged release fails", func() {
disaster := errors.New("nope")
@@ -280,17 +215,4 @@ var _ = Describe("In Command", func() {
Ω(inErr).Should(Equal(disaster))
})
})
Context("when getting the latest release fails", func() {
disaster := errors.New("nope-again")
BeforeEach(func() {
githubClient.LatestReleaseReturns(nil, disaster)
inResponse, inErr = command.Run(destDir, inRequest)
})
It("returns the error", func() {
Ω(inErr).Should(Equal(disaster))
})
})
})