From 13faed54724720fbbb6b362eb1c7425b293665ee Mon Sep 17 00:00:00 2001 From: Liz Dahlstrom Date: Wed, 2 Dec 2015 17:41:11 -0800 Subject: [PATCH] return errors in cases where there may be errors [#109289522] Signed-off-by: Toby Rumans --- github.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/github.go b/github.go index f82dbd5..b9ffb88 100644 --- a/github.go +++ b/github.go @@ -83,7 +83,7 @@ func (g *GitHubClient) ListReleases() ([]github.RepositoryRelease, error) { func (g *GitHubClient) GetReleaseByTag(tag string) (*github.RepositoryRelease, error) { release, res, err := g.client.Repositories.GetReleaseByTag(g.user, g.repository, tag) if err != nil { - return &github.RepositoryRelease{}, nil + return &github.RepositoryRelease{}, err } err = res.Body.Close() @@ -97,7 +97,7 @@ func (g *GitHubClient) GetReleaseByTag(tag string) (*github.RepositoryRelease, e func (g *GitHubClient) GetRelease(id int) (*github.RepositoryRelease, error) { release, res, err := g.client.Repositories.GetRelease(g.user, g.repository, id) if err != nil { - return &github.RepositoryRelease{}, nil + return &github.RepositoryRelease{}, err } err = res.Body.Close() @@ -143,7 +143,7 @@ func (g *GitHubClient) UpdateRelease(release github.RepositoryRelease) (*github. func (g *GitHubClient) ListReleaseAssets(release github.RepositoryRelease) ([]github.ReleaseAsset, error) { assets, res, err := g.client.Repositories.ListReleaseAssets(g.user, g.repository, *release.ID, nil) if err != nil { - return []github.ReleaseAsset{}, nil + return []github.ReleaseAsset{}, err } err = res.Body.Close()